From d80d44e2fc90461d4de27479e4a40f354e4d7f9e Mon Sep 17 00:00:00 2001 From: Celes Renata Date: Fri, 17 Apr 2026 03:28:22 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20update=20stale=20tests=20=E2=80=94=2050?= =?UTF-8?q?=20companies,=20normalization=20defaults,=20low-confidence=20th?= =?UTF-8?q?resholds?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ...est_integration_ingest_to_recommendation.py | 6 ++++-- tests/test_paper_trading_simulation.py | 18 +++++++++--------- tests/test_symbol_registry.py | 2 +- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/test_integration_ingest_to_recommendation.py b/tests/test_integration_ingest_to_recommendation.py index 32c8f32..ece164c 100644 --- a/tests/test_integration_ingest_to_recommendation.py +++ b/tests/test_integration_ingest_to_recommendation.py @@ -171,9 +171,11 @@ class TestExtractionStage: assert len(report.errors) > 0 def test_validate_extraction_rejects_bad_schema(self): - bad = {"summary": "test"} # missing required fields + bad = {"summary": "test"} # missing required fields — normalized with defaults report = validate_extraction(bad) - assert not report.valid + assert report.valid + assert report.parsed is not None + assert "incomplete_model_output" in report.parsed.extraction_warnings def test_extraction_result_matches_intelligence_schema(self): result = ExtractionResult.model_validate(SAMPLE_EXTRACTION_JSON) diff --git a/tests/test_paper_trading_simulation.py b/tests/test_paper_trading_simulation.py index 9037805..b0c5020 100644 --- a/tests/test_paper_trading_simulation.py +++ b/tests/test_paper_trading_simulation.py @@ -426,11 +426,11 @@ class TestRecommendationDrivenOrders: impacts = [ ImpactRow( document_id="doc-weak-1", - confidence=0.40, - novelty_score=0.3, - source_credibility=0.5, + confidence=0.20, + novelty_score=0.1, + source_credibility=0.2, sentiment="positive", - impact_score=0.3, + impact_score=0.1, catalyst_type="other", key_facts=["Minor update"], risks=[], @@ -438,11 +438,11 @@ class TestRecommendationDrivenOrders: ), ImpactRow( document_id="doc-weak-2", - confidence=0.35, - novelty_score=0.2, - source_credibility=0.4, - sentiment="positive", - impact_score=0.25, + confidence=0.15, + novelty_score=0.1, + source_credibility=0.2, + sentiment="negative", + impact_score=0.1, catalyst_type="other", key_facts=["Routine filing"], risks=[], diff --git a/tests/test_symbol_registry.py b/tests/test_symbol_registry.py index c940700..72832f1 100644 --- a/tests/test_symbol_registry.py +++ b/tests/test_symbol_registry.py @@ -102,4 +102,4 @@ def test_seed_sources_have_valid_types(): def test_seed_has_ten_companies(): - assert len(COMPANIES) == 10 + assert len(COMPANIES) == 50