From 419cf7558adb3a6867f6469fd44563a4a146dfe5 Mon Sep 17 00:00:00 2001
From: Celes Renata <celes@frameshift.net>
Date: Fri, 17 Apr 2026 07:10:21 +0000
Subject: [PATCH] fix: evidence articles missing on recommendations + Lucide
 title prop CI failure
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- recommendation worker: filter out non-UUID document IDs (synthetic
  pattern:* IDs from competitive signals) before inserting into
  recommendation_evidence table — the uuid cast was failing and
  silently dropping all evidence rows
- wrap executemany in try/except so partial failures don't lose all evidence
- SqlExplorer: wrap Lucide icons in <span title=...> instead of passing
  title prop directly (not supported by lucide-react, broke CI build)
---
 frontend/src/pages/SqlExplorer.tsx |  4 ++--
 services/recommendation/worker.py  | 24 ++++++++++++++++++++++--
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/frontend/src/pages/SqlExplorer.tsx b/frontend/src/pages/SqlExplorer.tsx
index e2861f1..162cceb 100644
--- a/frontend/src/pages/SqlExplorer.tsx
+++ b/frontend/src/pages/SqlExplorer.tsx
@@ -282,8 +282,8 @@ export function SqlExplorerPage() {
                   {t.columns.map((c) => (
                     <div key={c.name} className="flex items-center justify-between text-[10px]">
                       <span className="flex items-center gap-1 text-gray-400">
-                        {c.primary_key && <Key size={9} className="text-amber-500" title="Primary key" />}
-                        {c.references && <Link size={9} className="text-blue-400" title={`FK → ${c.references}`} />}
+                        {c.primary_key && <span title="Primary key"><Key size={9} className="text-amber-500" /></span>}
+                        {c.references && <span title={`FK → ${c.references}`}><Link size={9} className="text-blue-400" /></span>}
                         {c.name}
                       </span>
                       <span className="text-gray-600">{c.type}</span>
diff --git a/services/recommendation/worker.py b/services/recommendation/worker.py
index b514f2b..070707a 100644
--- a/services/recommendation/worker.py
+++ b/services/recommendation/worker.py
@@ -10,6 +10,7 @@ from __future__ import annotations
 
 import json
 import logging
+import uuid as _uuid
 from datetime import datetime, timezone
 
 import asyncpg
@@ -560,17 +561,36 @@ async def persist_recommendation(
     )
     rec_id = str(row["id"])
 
-    # Insert evidence citations with position-based weighting
+    # Insert evidence citations with position-based weighting.
+    # Filter out non-UUID document IDs (e.g. synthetic "pattern:..." IDs from
+    # competitive signal propagation) — the recommendation_evidence table
+    # requires a valid UUID foreign key to the documents table.
     evidence_rows: list[tuple[str, str, str, float]] = []
     for idx, doc_id in enumerate(supporting_ids):
+        try:
+            _uuid.UUID(doc_id)
+        except (ValueError, AttributeError):
+            continue
         weight = round(1.0 / (1.0 + idx * 0.1), 4)  # rank decay
         evidence_rows.append((rec_id, doc_id, "supporting", weight))
     for idx, doc_id in enumerate(opposing_ids):
+        try:
+            _uuid.UUID(doc_id)
+        except (ValueError, AttributeError):
+            continue
         weight = round(1.0 / (1.0 + idx * 0.1), 4)
         evidence_rows.append((rec_id, doc_id, "opposing", weight))
 
     if evidence_rows:
-        await pool.executemany(_INSERT_REC_EVIDENCE, evidence_rows)
+        try:
+            await pool.executemany(_INSERT_REC_EVIDENCE, evidence_rows)
+        except Exception:
+            logger.warning(
+                "Failed to insert %d evidence rows for recommendation %s",
+                len(evidence_rows),
+                rec_id,
+                exc_info=True,
+            )
 
     # Persist the eligibility/risk evaluation for audit trail
     if eligibility_result is not None: